Separate fetcher key validation from fetcher api url#14536
Separate fetcher key validation from fetcher api url#14536calixtus merged 7 commits intoJabRef:mainfrom
Conversation
|
Hey @Eduguimar! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow. |
262ca47 to
f9e8786
Compare
|
Your pull request conflicts with the target branch. Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line. |
Closes #14016
This pull request refactors the API key validation for web fetchers by replacing the getTestUrl() method with a more flexible isValidKey(String apiKey) in the CustomizableKeyFetcher interface. This allows each fetcher to implement its own specific logic for key validation, instead of assuming the key is always appended to a URL. The implementation was updated for IEEE, BiodiversityLibrary, Medline, SpringerNature, and Unpaywall fetchers.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)