Skip to content

Remove checkbox for Enable field formatters#14568

Merged
Siedlerchr merged 4 commits intomainfrom
removeDisableCheckbox
Dec 15, 2025
Merged

Remove checkbox for Enable field formatters#14568
Siedlerchr merged 4 commits intomainfrom
removeDisableCheckbox

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 10, 2025

We now have an apply button and this fixes the binding exception I encountered (see melting pot issue)

Follow up to #13852
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/1144

grafik

Steps to test

  1. Open quality -> Cleanup entries

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/[ I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@Siedlerchr
Copy link
Member Author

For further discussion: I think there should be warning dialog that Apply closes the dialog and executes the selected option. Maybe rename the button to Apply actions? I think only apply can be dangerous as it is not clear that he dialog closes

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: devcall labels Dec 10, 2025
@koppor
Copy link
Member

koppor commented Dec 11, 2025

For further discussion: I think there should be warning dialog that Apply closes the dialog and executes the selected option. Maybe rename the button to Apply actions? I think only apply can be dangerous as it is not clear that he dialog closes

Maybe "Run" or "Execute"? To be really different to the word "Apply" used in settings dialog.

@calixtus
Copy link
Member

Yes, UI will probably need more love here.
Maybe the button apply needs to be on the right with some chevron indicating - this is it, lets do it.

* upstream/main: (23 commits)
  Chore(deps): Bump org.mockito:mockito-core in /jablib (#14611)
  Chore(deps): Bump actions/download-artifact from 6 to 7 (#14605)
  Chore(deps): Bump com.squareup.okio:okio-jvm in /versions (#14613)
  Chore(deps): Bump DavidAnson/markdownlint-cli2-action from 21 to 22 (#14607)
  Chore(deps): Bump org.mockito:mockito-core in /versions (#14615)
  New translations jabref_en.properties (Italian) (#14596)
  Reset and Import for GroupsPreferences (#14572)
  Enable parallel tests (#14571)
  Copy over label in all cases
  Also allow adding label
  Fix workflow (#14586)
  Unassign issues on stale (#14585)
  Increase max assignments from 1 to 2
  Reduce time for initial PR to 14 days (#14580)
  New Crowdin updates (#14579)
  chore(deps): update dependency org.eclipse.jgit:org.eclipse.jgit.pgm to v7.5.0.202512021534-r (#14577)
  Fix stale closing
  Try to fix commenting on closed PRs
  Add 15 non-standard BibLaTeX entry types with .withType() method (#14534)
  New Crowdin updates (#14570)
  ...
@Siedlerchr
Copy link
Member Author

Let's tackle this in a follow up pr

@Siedlerchr Siedlerchr enabled auto-merge December 14, 2025 20:31
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 14, 2025
Merged via the queue into main with commit a658b64 Dec 15, 2025
52 checks passed
@Siedlerchr Siedlerchr deleted the removeDisableCheckbox branch December 15, 2025 00:30
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
* Remove checkbox for Enable field formatters

We now have an apply button

Follow up to JabRef#13852
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/1144

* fix l10n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cleanup-ops status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants