Skip to content

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 10, 2025

We now have an apply button and this fixes the binding exception I encountered (see melting pot issue)

Follow up to #13852
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/1144

grafik

Steps to test

  1. Open quality -> Cleanup entries

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/[ I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@Siedlerchr
Copy link
Member Author

For further discussion: I think there should be warning dialog that Apply closes the dialog and executes the selected option. Maybe rename the button to Apply actions? I think only apply can be dangerous as it is not clear that he dialog closes

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: devcall labels Dec 10, 2025
@koppor
Copy link
Member

koppor commented Dec 11, 2025

For further discussion: I think there should be warning dialog that Apply closes the dialog and executes the selected option. Maybe rename the button to Apply actions? I think only apply can be dangerous as it is not clear that he dialog closes

Maybe "Run" or "Execute"? To be really different to the word "Apply" used in settings dialog.

@calixtus
Copy link
Member

Yes, UI will probably need more love here.
Maybe the button apply needs to be on the right with some chevron indicating - this is it, lets do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cleanup-ops status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants