-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix groups not visible in sidebar after importing library (#13684) #14584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added group merging logic in ImportEntriesViewModel - Groups with same name are merged recursively - Target library with no groups receives complete group tree - Metadata update triggers UI refresh Fixes JabRef#13684
|
This pull requests was closed without merging. You have been unassigned from the respective issue #13684. |
- Added mergeGroupsFromImport() and mergeGroupTrees() methods to ImportEntriesViewModel - Groups from imported libraries now properly merge with existing groups - Fixed CHANGELOG.md formatting Fixes JabRef#13684
|
This pull requests was closed without merging. You have been unassigned from the respective issue #13684. |
|
@omkarrr2533 Please either keep the PR open and work on the task - or keep it closed and move on. Please do not play an open-/close game with our bots. |
Refactor group merging logic and improve UI refresh handling after import.
|
Your code currently does not meet JabRef's code guidelines. IntelliJ auto format covers some cases. There seem to be issues with your code style and autoformat configuration. Please reformat your code (Ctrl+Alt+L) and commit, then push. In special cases, consider using |
Closes #13684
Description
When importing a
.bibfile into another library using File → Import, groups from the imported file were not appearing in the left sidebar, even though thegroupsfield was correctly set in each entry. This PR implements group merging logic to ensure imported groups are properly displayed alongside existing groups in the target library.Steps to test
Create first library with group "A":
A.biband close JabRefCreate second library with group "B":
B.bib(keep this library open)Import and verify:
B.bibstill open, go to File → ImportA.biband import itTest edge cases:
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average userImplementation Details
Files Modified:
ImportEntriesViewModel.java: AddedmergeGroupsFromImport()method to merge groups from imported library with target library's existing groups, andmergeGroupTrees()helper method for recursive mergingCHANGELOG.md: Added entry documenting the fixKey Features:
Additional Notes
This fix addresses the core issue where JabRef's import functionality was only importing entries and their metadata fields (including the
groupsfield), but was not extracting and merging the actual group tree structure from the imported library's metadata. The group information existed in the entries but was not reflected in the sidebar's group tree.Note: As per issue requirements, documentation updates at https://docs.jabref.org/advanced/main-window will be handled in a follow-up after this PR is merged and tested.