-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Reset and Import for SidePanePreferences #14589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
56f71a4 to
2c7f4db
Compare
… Methods in SidePanePreferences and added the getSidePanePreferencesFromBackingStore method in JabRefGuiPreferences with proper updates in clear and importPreferences.
| private SidePanePreferences() { | ||
| this( | ||
| Set.of(), // Default visible pane | ||
| Map.of(), // Default preferred positions | ||
| 0 // Default web search fetcher index | ||
| ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private SidePanePreferences() {
this(
EnumSet.of(SidePaneType.WEB_SEARCH, SidePaneType.GROUPS), // Default visible panes (OPEN_OFFICE omitted)
Collections.emptyMap(), // Default preferred positions
0 // Default web search fetcher index
);
}Hi @calixtus , is this the approach that you're looking for?
calixtus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
|
Hi @calixtus, can you please check if the snippet I've added in the comments of the review is the one you want? |

Closes #14407
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)