-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix for issue 14249 #14593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for issue 14249 #14593
Conversation
|
The title of the pull request must not start with "Fix for issue xyz". Please use a concise one-line summary that explains what the fix or change actually does. Example of a good title: "Prevent crash when importing malformed BibTeX entries". |
|
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
|
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
|
Im strongly against adding a new button to the search bar. This will be too crowded. You need to make an argument, why a button for filtering by date ranges must sit inside the search bar and why it is so special in contrast to a filter button for something else. This needs a more general solution. See #8850 |
|
Please use a proper title for your PR. "Fix for issue xxx" is not acceptable. |
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
Closes #14249
This is a draft pull request which contains an additional button for filtering by date ranges in the search bar. The button works at the moment with a hard coded regular expression inside, so this still needs to be generalized. We have an idea on how to solve this, and will try to implement it.
Steps to test
To test this, press the button for date range (right now a placeholder with a check-mark) and type "[1111-11]-[1111-11]" in the search bar. It will then filter the results based on the hard coded "200[5-9]|201[0-9]".
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)