Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm currently working on a project using
permanent_records
. Unfortunately we have invalid records in the database. These cannot be soft-deleted becausepermanent_records
does not pass validation options to dependent records (#61).It is possible to use
record.destroy(validate: false)
to ignore validations on the current record. But any associated record does not receive the options.I dig a bit through the code and I guess it will be quite difficult to pass those options. In most cases
ActiveRecord
is callingdestroy
. Do you already have a plan how to solve that?However, while digging, I asked myself why the record is validated in the first place. I understand the reason for validation when reviving a record. But when soft-deleting a record, only the
deleted_at
attribute is set. Is it really necessary to validate that? Because the records are deleted, I don't necessarily mind that they are invalid.Proposed changes
Thank you for having a look!