Added support for getting the cover art from mpd #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Thanks for taking the time to rewrite this. There are some issues I've raised with your implementation which will need addressing, but it's mostly just simplifying things and refactoring.
In future, can you please have a read of the contributing guide - it's very short but has a few requirements I ask people to stick to in order to make both our lives easier.
The build is also failing currently, which will need to be addressed of course.
As suggested previously, This commit uses message passing to send the image from the client to the main thread while retaining the original way of setting the album art.
Removed the patch section for ahash from Cargo.toml
Due to the previous commit, cargo could not find the proper ahash version, ran cargo update to fix that.
Now using gdk's image parser for parsing the mpd's thumbnails that are read from readpicture command
|
I have done all the requested changes |
|
What kind of Clippy rules are you using |
JakeStanger
requested changes
Mar 2, 2024
The defaults: ironbar/.github/workflows/build.yml Line 61 in 3df01ea |
Only sending the GetAlbumArt signal when track changes and the cover_art path does not exist.
|
Please fix the merge conflict before I review |
JakeStanger
added
M:Music
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in the previous PR (#466), this PR implements displaying cover art from mpd using the readpicture command