Merge pull request #482 from wikimedia/upstream/midi-duration

JamesHeinrich · web-flow · commit 28a98cc5a646 · 2026-01-16T10:49:38.000-05:00
MIDI: Fix duration for files without tempo events
diff --git a/getid3/module.audio.midi.php b/getid3/module.audio.midi.php
@@ -330,6 +330,15 @@ public function Analyze() {
 			}
 		}
 
+		// Fallback: If playtime_seconds is still empty/zero, estimate using default tempo
+		// 120 BPM = 0.5 per quarter note = 480 quarternote ticks
+		if (empty($info['playtime_seconds']) && !empty($thisfile_midi['totalticks'])) {
+			$ticksPerQuarterNote = isset($thisfile_midi_raw['ticksperqnote']) ? $thisfile_midi_raw['ticksperqnote'] : 480;
+			if ($ticksPerQuarterNote > 0) {
+				$totalQuarterNotes = $thisfile_midi['totalticks'] / $ticksPerQuarterNote;
+				$info['playtime_seconds'] = $totalQuarterNotes * 0.5;
+			}
+		}
 
 		if (!empty($info['playtime_seconds'])) {
 			$info['bitrate'] = (($info['avdataend'] - $info['avdataoffset']) * 8) / $info['playtime_seconds'];

Original file line number	Diff line number	Diff line change
`@@ -330,6 +330,15 @@ public function Analyze() {`
`330`	`330`	`}`
`331`	`331`	`}`
`332`	`332`
	`333`	`+ // Fallback: If playtime_seconds is still empty/zero, estimate using default tempo`
	`334`	`+ // 120 BPM = 0.5 per quarter note = 480 quarternote ticks`
	`335`	`+ if (empty($info['playtime_seconds']) && !empty($thisfile_midi['totalticks'])) {`
	`336`	`+ $ticksPerQuarterNote = isset($thisfile_midi_raw['ticksperqnote']) ? $thisfile_midi_raw['ticksperqnote'] : 480;`
	`337`	`+ if ($ticksPerQuarterNote > 0) {`
	`338`	`+ $totalQuarterNotes = $thisfile_midi['totalticks'] / $ticksPerQuarterNote;`
	`339`	`+ $info['playtime_seconds'] = $totalQuarterNotes * 0.5;`
	`340`	`+ }`
	`341`	`+ }`
`333`	`342`
`334`	`343`	`if (!empty($info['playtime_seconds'])) {`
`335`	`344`	`$info['bitrate'] = (($info['avdataend'] - $info['avdataoffset']) * 8) / $info['playtime_seconds'];`