Merge pull request #481 from wikimedia/upstream/shortfiles

JamesHeinrich · web-flow · commit 4bf44f69bb1b · 2026-01-16T10:48:44.000-05:00
ID3v1 should not parse files shorter than 128 bytes
diff --git a/getid3/module.tag.id3v1.php b/getid3/module.tag.id3v1.php
@@ -29,6 +29,9 @@ public function Analyze() {
 		if (!getid3_lib::intValueSupported($info['filesize'])) {
 			$this->warning('Unable to check for ID3v1 because file is larger than '.round(PHP_INT_MAX / 1073741824).'GB');
 			return false;
+		} elseif ($info['filesize'] < 128) {
+			$this->warning('Unable to check for ID3v1 because file is too small');
+			return false;
 		}
 
 		if($info['filesize'] < 256) {

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,9 @@ public function Analyze() {`
`29`	`29`	`if (!getid3_lib::intValueSupported($info['filesize'])) {`
`30`	`30`	`$this->warning('Unable to check for ID3v1 because file is larger than '.round(PHP_INT_MAX / 1073741824).'GB');`
`31`	`31`	`return false;`
	`32`	`+ } elseif ($info['filesize'] < 128) {`
	`33`	`+ $this->warning('Unable to check for ID3v1 because file is too small');`
	`34`	`+ return false;`
`32`	`35`	`}`
`33`	`36`
`34`	`37`	`if($info['filesize'] < 256) {`