Skip to content

Stop calling imagedestroy in PHP8+ #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZabeMath wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Stop calling imagedestroy in PHP8+ #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions getid3/module.graphic.bmp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,12 +676,16 @@ public function PlotBMP(&$BMPinfo) {
}
if (headers_sent()) {
echo 'plotted '.($BMPinfo['resolution_x'] * $BMPinfo['resolution_y']).' pixels in '.(time() - $starttime).' seconds<BR>';
imagedestroy($im);
if (PHP_VERSION_ID < 80000) { // imagedestroy does nothing after PHP8 and give deprecation warnings in PHP8.5
imagedestroy($im);
}
exit;
} else {
header('Content-type: image/png');
imagepng($im);
imagedestroy($im);
if (PHP_VERSION_ID < 80000) {
imagedestroy($im);
}
return true;
}
}
Expand Down