Python3 and typehint #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
September 8, 2024 19:16
Add some of first type hints. Make Methods of ShellyBase abstract methods instead of raising an exception. This should be done in the child implementations. Small format fixes.
…some dunder-style
…udo dunder-methods. Apply type hints for those. Fix typo kalvin -> kelvin
Add type hints in initializers. Initialize some properties of gen1 that were not initialized before. Add types-request to requirements for better type hints.
…re later extracted with those keywords in signature Only relay() method is an exception for that. Is signature is not final for now
…hod to throw exception
Add some other type hints
…ellyPy into python3_and_typehint
…have propper doc and autofill in ides like vscode and pycharm. Put all docstrings to base class. Make base class private (_ShellyBase). Add some missing initial descriptions (should be improved later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the codebase by adding typehints fixing some docstrings and a lot more.
Also removed old python2 compatibility since it is EOL.