Skip to content

Implemented custom font specification for config export image cli #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jasonm23
Copy link

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

Re-implementation of custom font settings via

config export image \
  [--font MyNerdFontExample.ttf/otf] \
  [--font-regular MyNerdFontExample.ttf/otf] \
  [--font-bold MyNerdFontExample-Bold.ttf/otf] \
  [--font-italic MyNerdFontExample-Italic.ttf/otf]

Reduced testing profile to only include new functionality in the PR, since golang opentype is responsible for reading fonts etc.

@JanDeDobbeleer
Copy link
Owner

Thanks for submitting a PR to the project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

@jasonm23
Copy link
Author

@JanDeDobbeleer - note that you have write permission to ocodo/oh-my-posh already.

@JanDeDobbeleer
Copy link
Owner

@jasonm23 that's an automated message. You should see that option here in the sidebar.

@jasonm23
Copy link
Author

@jasonm23 that's an automated message. You should see that option here in the sidebar.

Should, isn't. Mentioned in the previous PR. You have write access to the whole repo (ocodo/oh-my-posh) You remember the other PR, right?

@jasonm23
Copy link
Author

For ref:

Screen Shot 2025-06-16 at 16 23 32

@jasonm23
Copy link
Author

Screen Shot 2025-06-16 at 16 25 25

@JanDeDobbeleer JanDeDobbeleer force-pushed the main branch 3 times, most recently from eb42120 to 3bf3592 Compare June 25, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants