Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to inherit from GraphQLHttpMiddleware #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Shane32
Copy link

@Shane32 Shane32 commented Jan 21, 2024

Refactoring for adding/fixing these issues:

  • By inheriting from GraphQLHttpMiddleware, requests now honor all of these options which were not supported previously:
    • AuthenticationSchemes
    • AuthorizedPolicy
    • AuthorizedRoles
    • AuthorizationRequired
    • DefaultResponseContentType
    • EnableBatchedRequests
    • ExecuteBatchedRequestsInParallel
    • ReadQueryStringOnPost
    • ValidationErrorsReturnBadRequest
  • Moves AddGraphQLUpload to a builder method within the GraphQL namespace
  • Bumps version to 4.0.0
  • Built for all TFMs supported by GraphQL.Server.Transports.AspNetCore
    • .NET Framework with ASP.NET Core 2.1
    • .NET Core 2.1
    • .NET Core 3.1 and newer
  • Adds license, readme and directory.props to solution
  • Enable NRT annotations
  • Embed readme within nuget package, configured so it displays on nuget.org
  • Embed license file within nuget package
  • Embed debugging symbols
  • Add .NET 8.0 testing and update ci workflow
  • Add error classes
  • Bump GraphQL.Server.Transports.AspNetCore dependency version to 7.6.0
  • Rewrite sample to use top-level statements and work for kestrel or IIS out of the box
  • Removed the UserContextFactory option as this feature is already provided by GraphQL.Server via AddUserContextBuilder
  • Refactored deserialization of responses to eliminate duplicated code that exists within the main GraphQL library
  • Added xml comments where missing

These changes result in a net reduction of 200 lines of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant