Studio.js: replace docker client with CLI communication #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lottspot
force-pushed
the
studio-docker-cli
branch
from
669d3ba to
7226f89
Compare
Interacting with the docker CLI enables the transparent use of other docker-compatible runtimes, such as podman or nerdctl.
lottspot
force-pushed
the
studio-docker-cli
branch
from
7226f89 to
dfdc960
Compare
lottspot
changed the title
Member
|
@lottspot love this! I was just wresting with Dockerode trying to figure out how to get it to respect docker context and this gets it done way better. Made some minor changes to keep output consistent |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interacting with the docker CLI enables the transparent use of other docker-compatible runtimes, such as podman or nerdctl.