Skip to content

rework hash #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jwoodmanbuildium
Copy link
Contributor

@jwoodmanbuildium jwoodmanbuildium commented Jun 2, 2025

@jeremydmiller - I've reworked the initial PR to handle #398 with some additional changes after the feedback/revert.

  • Removed the conditional logic on the hot paths by adding an InstanceMapFactory. This new class will generate a data structure specific implementation of InstanceMap. This avoids all of the conditional checks when retrieving/updating the hashes.
  • Fixed the breaking tests - this was just an updated constructor that was not calling the base constructor appropriately.
  • Added a static property to define the default InstanceMap behavior. This uses the ImHashMap by default, but can be updated in code or through an environment variable (added the latter option so tests can be executed against both behaviors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant