Skip to content

Asserting exceptions are actually thrown fails tests in UniqueIndexTests.cs #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shield1739 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Asserting exceptions are actually thrown fails tests in UniqueIndexTests.cs #2771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 8 additions & 32 deletions src/DocumentDbTests/Indexes/UniqueIndexTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,8 @@ public void
session.Store(secondDocument);

//3. Unique Exception Was thrown
try
{
session.SaveChanges();
}
catch (DocumentAlreadyExistsException exception)
{
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}
var exception = Should.Throw<DocumentAlreadyExistsException>(() => session.SaveChanges());
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}

[Fact]
Expand All @@ -109,14 +103,8 @@ public void
session.Store(secondDocument);

//3. Unique Exception Was thrown
try
{
session.SaveChanges();
}
catch (DocumentAlreadyExistsException exception)
{
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}
var exception = Should.Throw<DocumentAlreadyExistsException>(() => session.SaveChanges());
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}

[Fact]
Expand All @@ -139,14 +127,8 @@ public void
session.Events.Append(secondEvent.UserId, secondEvent);

//3. Unique Exception Was thrown
try
{
session.SaveChanges();
}
catch (MartenCommandException exception)
{
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}
var exception = Should.Throw<MartenCommandException>(() => session.SaveChanges());
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}

[Fact]
Expand All @@ -166,13 +148,7 @@ public void
session.Events.Append(secondEvent.UserId, secondEvent);

//3. Unique Exception Was thrown
try
{
session.SaveChanges();
}
catch (DocumentAlreadyExistsException exception)
{
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}
var exception = Should.Throw<DocumentAlreadyExistsException>(() => session.SaveChanges());
((PostgresException)exception.InnerException)?.SqlState.ShouldBe(UniqueSqlState);
}
}