Improved select parsing #3782
Open
Improved select parsing #3782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for string.compare to test case and culture variants
…ct to type with constructor logic
…nnot be translated to sql
jakobt
reviewed
May 2, 2025
| break; | ||
| case CompareOptions co: | ||
| compareOptions = co; | ||
| break; |
There was a problem hiding this comment.
Would probably make sense to have some default in this case statement also resulting in the BadLinqExpression if people would try to use the overloads with substrings etc. like this one https://learn.microsoft.com/en-us/dotnet/api/system.string.compare?view=net-9.0#system-string-compare(system-string-system-int32-system-string-system-int32-system-int32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws exceptions if it is unable to parse a select projection.
Before, it would either not run the
Selectbut still return the query without the projection, or return an empty queryable. Now, it throws an exception if it cannot parse.