Skip to content

Use raw string literal #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use raw string literal #3932

wants to merge 5 commits into from
+27 −19

Conversation

HakamFostok
Copy link
Contributor

gfoidl
gfoidl reviewed Aug 28, 2025
View reviewed changes
@HakamFostok HakamFostok requested a review from gfoidl August 28, 2025 16:31
gfoidl
gfoidl reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I meant (in addition to the intendation you did in the last commit).

@HakamFostok HakamFostok requested a review from gfoidl August 28, 2025 17:42
@HakamFostok
Copy link
Contributor Author

@gfoidl I had to close this PR and reopen a new one because the pipeline failed, and I had no way to start the pipeline again without doing this. Please refer to the newly opened one

@gfoidl
Copy link
Contributor

gfoidl commented Aug 28, 2025

For reference: #3933

Did closing and re-opening this PR not restart the pipeline?

@HakamFostok HakamFostok reopened this Sep 1, 2025
@HakamFostok
Copy link
Contributor Author

HakamFostok commented Sep 1, 2025 •
edited
Loading

@gfoidl
Yeah, that makes it work, thanks a lot for letting me know, I did not think of that,
TBH, I am not that experienced with opening PRs to public repos.
Thanks for letting me know again

@HakamFostok HakamFostok requested a review from gfoidl September 1, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gfoidl gfoidl gfoidl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HakamFostok @gfoidl