Enable nullable reference types in Oakton project #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturDorochowicz
force-pushed
the
nullable
branch
from
416a683 to
af5bdb2
Compare
Skipped two files that had `#nullable enable` at the top. This change allows to preserve the original meaning of declarations w.r.t. nullability.
Some files already used nullable reference types. They don't need disable annotations pragma.
ArturDorochowicz
force-pushed
the
nullable
branch
from
af5bdb2 to
4c29d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nullable reference types in Oakton project. This enables nullability warnings for the project (a number of them are reported now). Also, it will default newly added files to be nullable-enabled.
Prior nullable-oblivious types are preserved by adding
#nullable disable annotationsto nearly all files (apart from two that had#nullable enablepragmas, some files inInternal.Conversionsthat used nullable references in signatures, and some files where the pragma is clearly redundant).