Bug fix to handle index name containing upper case chars #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mysticmind It seems its only the create statement that we are quoting the name in case of uppercase characters in this change but as far as i remember you will need to quote every time you reference it in the future to, i would imagine Weasel has some places where indexes are dropped too? |
|
@jakobt i will take a look and confirm things for the drop statement. I might tweak the logic a bit to deal with it. |
|
@jakobt Quick note, it is dealt with properly now for both create and drop. |
jeremydmiller
deleted the
handle_table_index_name_with_upper_case_chars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that if you don't add quotes around index name containing upper case chars, Postgres will convert it to lower case index name.