Welcome improvements

[Aaron-CYF]

Hi.

I was bothered by the Welcome/Installation options not being togglable, so I decided to try to fix it myself.
I hope this works.

Note:
I noticed that Performance mode sets FadeDuration and blur. I'm not 100% what the default values should be, but I think I found the right ones?

[!FadeDuration 100 "#JaxCore\Main"][!WriteKeyValue Variables Set.Blur Blur "#@#Vars.inc"]

[EnhancedJax]

Thank you! Why revert the changes though?

[Aaron-CYF]

Thank you! Why revert the changes though?

Hi, sorry, was attempting to make diff work on the .inc files.

I have added them back

[Aaron-CYF]

I'm a little new to github so i'm trying to figure things out.
Github is still treating them as binary files sadly, shall i remove the .gitattributes file?

[Aaron-CYF]

I found that the Rainmeter.data file is storing whether gamemode is on or not.
My first try was using RunCommand plugin to parse the file with cmd, which while worked seemed only be able to display the output and not use it in any measure.
Then I found I was able to just parse it using WebParser which was much easier.
I saw that there was already a AHKFunction for toggling gamemode off, so I utilized that.

[Aaron-CYF]

I saw that toggling Hardware acceleration reloads Rainmeter completely and toggling Game Mode reloads the Rainmeter settings windows (because the script is setting the option through that then closing it)

I thought it might be better to toggle these options temporarily using variables then having an apply button appear to apply them before continuing. But this would change how the page works and is a bit more work, so I decided to do it this way for now.

Let me know what you think, I can do it first and you can try it see if you like it.

[Aaron-CYF]

I found you can see my changes more easily here:
https://github.com/Aaron-CYF/JaxCore/blame/Welcome-Improvements/Accessories/Welcome/Page/2.inc

It shows on the left which commit added the line.

[EnhancedJax]

Thanks for the PR. I'll review the changes later down this week <3

[EnhancedJax]

I'm a little new to github so i'm trying to figure things out.
Github is still treating them as binary files sadly, shall i remove the .gitattributes file?

This behavior is normal and should be preserved. The files are saved with UTF-16 encoding, which Github recognizes as binary files.

[Aaron-CYF]

I'm a little new to github so i'm trying to figure things out.
Github is still treating them as binary files sadly, shall i remove the .gitattributes file?

This behavior is normal and should be preserved. The files are saved with UTF-16 encoding, which Github recognizes as binary files.

Just so we are clear, are you saying the binary interpretation should be preserved or just the UTF-16 encoding?

[EnhancedJax]

Just so we are clear, are you saying the binary interpretation should be preserved or just the UTF-16 encoding?

I am pretty sure you can't "remove" the binary interpretation with non-UTF-8 encoding...

[Aaron-CYF]

Just so we are clear, are you saying the binary interpretation should be preserved or just the UTF-16 encoding?

I am pretty sure you can't "remove" the binary interpretation with non-UTF-8 encoding...

Please check my latest commits. I just did ;)