tests: add unit tests for matrix class increasing math utilities coverage #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanPhilippeKernel
added
enhancement
jnyfah
requested changes
Jun 4, 2025
|
|
||
| // ========== INVERSE TESTS ========== | ||
|
|
||
| TEST(MatrixTest, Inverse3x3) |
There was a problem hiding this comment.
Can we have inverse for 4x4 too
There was a problem hiding this comment.
Yup, i'm working on it ;)
| EXPECT_NEAR(result(0, 1), 1.0f, EPSILON); // (0*0) + 1 - 0 = 1 | ||
| EXPECT_NEAR(result(1, 1), 2.0f, EPSILON); // (1*2) + 1 - 1 = 2 | ||
| } | ||
|
|
||
| TEST(MatrixTest, ConstructionAndIndexingFloat) |
There was a problem hiding this comment.
I think this should be removed since there is not a comprehensive ParameterConstruction test
There was a problem hiding this comment.
Should I remove the entire chainedOperations test ?
There was a problem hiding this comment.
ohh @AmanMenda i meant just remove the ConstructionAndIndexingFloat test
Comment on lines
+186
to
+210
| TEST(MatrixTest, MatrixMultiplication) | ||
| { | ||
| Mat3f m1(1, 2, 3, 0, 1, 4, 5, 6, 0); | ||
| Mat3f m2 = Identity<Mat3f>(); | ||
|
|
||
| Mat3f result = m1 * m2; | ||
|
|
||
| // Multiplying by identity should result in the original matrix | ||
| for (size_t i = 0; i < 3; ++i) | ||
| { | ||
| for (size_t j = 0; j < 3; ++j) | ||
| { | ||
| EXPECT_NEAR(result(i, j), m1(i, j), EPSILON); | ||
| } | ||
| } | ||
|
|
||
| // Test specific multiplication | ||
| Mat3f a = Identity<Mat3f>(); | ||
| Mat3f b(2, 0, 0, 0, 2, 0, 0, 0, 2); | ||
| Mat3f product = a * b; | ||
|
|
||
| EXPECT_NEAR(product(0, 0), 2.0f, EPSILON); | ||
| EXPECT_NEAR(product(1, 1), 2.0f, EPSILON); | ||
| EXPECT_NEAR(product(2, 2), 2.0f, EPSILON); | ||
| } |
There was a problem hiding this comment.
Add a Matrix-Vector Multiplication Testing
…nction; add the * operator support for mat4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.