Skip to content

tests: add unit tests for matrix class increasing math utilities coverage #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

tests: add unit tests for matrix class increasing math utilities coverage #454

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d80bb2c
add unit tests for matrix class construction, indexing, error conditions
AmanMenda Jun 1, 2025
7af64ca
Revert "add unit tests for matrix class construction, indexing, error…
AmanMenda Jun 1, 2025
0a7a324
fix: empty content in last push
AmanMenda Jun 1, 2025
d522c46
fix method call format in matrix.h
AmanMenda Jun 1, 2025
04468ea
add 3x3 inverse test
AmanMenda Jun 4, 2025
6634427
fix inverse method's return type error
AmanMenda Jun 4, 2025
5c04ab7
remove extra spaces in 3x3 test
AmanMenda Jun 4, 2025
4df7f00
fix format
AmanMenda Jun 4, 2025
096e568
fix mat4 param construction and handle div by zero case in inverse fu…
AmanMenda Jun 8, 2025
959cc36
fix format issues
AmanMenda Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ZEngine/ZEngine/Core/Maths/Matrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ namespace ZEngine::Core::Maths

Mat2()
{
Helpers::secure_memset(m_data, 0, sizeof(m_data));
Helpers::secure_memset(m_data, 0, sizeof(m_data), sizeof(m_data));
}

Mat2(T m00, T m01, T m10, T m11)
Expand Down Expand Up @@ -192,7 +192,7 @@ namespace ZEngine::Core::Maths

Mat3()
{
Helpers::secure_memset(m_data, 0, sizeof(m_data));
Helpers::secure_memset(m_data, 0, sizeof(m_data), sizeof(m_data));
}

Mat3(T m00, T m01, T m02, T m10, T m11, T m12, T m20, T m21, T m22)
Expand Down Expand Up @@ -270,7 +270,7 @@ namespace ZEngine::Core::Maths

float invDet = 1.0f / dot(r2, c);

return Mat<T>(r0.x * invDet, r0.y * invDet, r0.z * invDet, r1.x * invDet, r1.y * invDet, r1.z * invDet, r2.x * invDet, r2.y * invDet, r2.z * invDet);
return Mat3<T>(r0.x * invDet, r0.y * invDet, r0.z * invDet, r1.x * invDet, r1.y * invDet, r1.z * invDet, r2.x * invDet, r2.y * invDet, r2.z * invDet);
};
};

Expand All @@ -280,7 +280,7 @@ namespace ZEngine::Core::Maths
using Matrix<T, 4, 4>::m_data;
Mat4()
{
Helpers::secure_memset(m_data, 0, sizeof(m_data));
Helpers::secure_memset(m_data, 0, sizeof(m_data), sizeof(m_data));
}

Mat4(T m00, T m01, T m02, T m03, T m10, T m11, T m12, T m13, T m20, T m21, T m22, T m23, T m30, T m31, T m32, T m33)
Expand Down
Loading