Skip to content

Conversation

@jimsleon
Copy link

React-select is great and easy to use. I had a simple wrapper around react-select to allow non-object options like string, number, etc. for simple use case so that I don't need to construct object with 'label' & 'value' from simple type by overriding getOptionValue() and getOptionLabel(), but found it doesn't work.(display works fine but can't select a value), it does work for multiple selection. After looked into code I found it is caused by clearValue() which assuming 'option' is object. cleanValue() is only used for processing 'value' property, so please review if this can be merged.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2020

💥 No Changeset

Latest commit: 1598332

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1598332:

Sandbox Source
react-codesandboxer-example Configuration

@L3au
Copy link

L3au commented May 25, 2020

@jimsleon Nice work. The bad news is I don't think the collaborator would accept this change after I checked the early related issues and PR.

@jimsleon
Copy link
Author

@jimsleon Nice work. The bad news is I don't think the collaborator would accept this change after I checked the early related issues and PR.

Probably, but my change is a little bit different, I didn't change any contract of react-select. 🤞

@bladey bladey added uncertain and removed v3 labels May 26, 2020
@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome enhancement and removed uncertain labels Jun 4, 2020
@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome pr/enhancement PRs that are specifically enhancing the project and removed pr/needs-review PRs that need to be reviewed to determine outcome category/enhancement labels Jun 24, 2020
@bladey bladey requested review from JedWatson and bladey July 1, 2020 03:36
@bladey bladey added pr/in-review PRs currently in review by maintainers for the next release and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Jul 1, 2020
@bladey
Copy link
Contributor

bladey commented Jul 1, 2020

@JedWatson to review and comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/enhancement PRs that are specifically enhancing the project pr/in-review PRs currently in review by maintainers for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants