Throw the proper exception when a video requiring purchasing if fetch…

…ed and disable comment tests
JeongEunSeong · Apr 2, 2024 · 5afc6f0 · 5afc6f0
1 parent 84ef108
commit 5afc6f0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/lib/src/videos/comments/comments_client.dart b/lib/src/videos/comments/comments_client.dart
@@ -12,6 +12,8 @@ class CommentsClient {
 
   /// Returns a [List<Comment>] containing the first batch of comments or null if the video has comments disabled.
   /// You can use [CommentsList.nextPage()] to get the next batch of comments.
+  ///
+  /// WARNING: As of v2.2.0 this is broken due to yt updates.
   Future<CommentsList?> getComments(Video video) async {
     if (video.watchPage == null) {
       return null;

diff --git a/lib/src/videos/streams/stream_client.dart b/lib/src/videos/streams/stream_client.dart
@@ -120,15 +120,20 @@ class StreamClient {
       {required bool fullManifest}) async* {
     try {
       // Use await for instead of yield* to catch exceptions
-      await for (final stream in _getStream(videoId, VideoController.androidTestSuiteClient)) {
+      await for (final stream
+          in _getStream(videoId, VideoController.androidTestSuiteClient)) {
         yield stream;
       }
       if (fullManifest) {
-        await for (final stream in _getStream(videoId, VideoController.androidClient)) {
+        await for (final stream
+            in _getStream(videoId, VideoController.androidClient)) {
           yield stream;
         }
       }
-    } on VideoUnplayableException {
+    } on VideoUnplayableException catch (e) {
+      if (e is VideoRequiresPurchaseException) {
+        rethrow;
+      }
       yield* _getCipherStream(videoId);
     }
   }

diff --git a/test/comments_client_test.dart b/test/comments_client_test.dart
@@ -18,7 +18,7 @@ void main() {
     expect(comments.length, greaterThanOrEqualTo(1));
     expect(comments.totalLength, greaterThanOrEqualTo(1));
     expect(comments.first.isHearted, false);
-  });
+  }, skip: 'Currently broken');
 
   test('Comments of video with no comments should be empty', () async {
     const videoUrl = 'https://www.youtube.com/watch?v=A3egPTy9hhA';