Add experiment-level selection mode configuration for grouped trials #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added UsingFeatureFlag(), UsingConfigurationKey(), and UsingCustomMode() methods to ExperimentBuilder - Added extension methods for UsingVariantFeatureFlag() and UsingOpenFeature() in respective packages - Modified ServiceExperimentBuilder to support experiment-level selection mode inheritance - Updated IExperimentDefinitionBuilder interface to include ApplyExperimentSelectionMode method Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
- Created comprehensive tests for UsingFeatureFlag, UsingConfigurationKey, and UsingCustomMode on ExperimentBuilder - Added tests for trial-level overrides - All 1775 tests pass including 8 new tests Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
- Added HasTrialSelectionMode() helper method to make selection mode override logic more explicit - Updated test documentation to clarify it tests selection mode functionality Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ability to define a single experiment key for trials
Add experiment-level selection mode configuration for grouped trials
Dec 30, 2025
Owner
|
@copilot Ensure this change is documented (not as a change, but just as an option in our docs) |
- Added comprehensive section in selection-modes.md explaining the new feature - Updated core-concepts.md example to demonstrate shared selection mode - Documented all available methods (UsingFeatureFlag, UsingConfigurationKey, UsingCustomMode) - Included extension package methods (UsingVariantFeatureFlag, UsingOpenFeature) - Explained trial-level override behavior - Provided before/after examples showing benefits Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Contributor
Author
Documentation added in commit 05ab303. The feature is now documented in:
The documentation shows how to use |
JerrettDavis
approved these changes
Dec 30, 2025
Code Coverage |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage ? 91.86%
=======================================
Files ? 157
Lines ? 5407
Branches ? 795
=======================================
Hits ? 4967
Misses ? 440
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExperimentBuilderclassUsingFeatureFlag()method onExperimentBuilderUsingConfigurationKey()method onExperimentBuilderUsingCustomMode()method onExperimentBuilderExperimentFramework.FeatureManagementforUsingVariantFeatureFlag()onExperimentBuilderExperimentFramework.OpenFeatureforUsingOpenFeature()onExperimentBuilderSummary
Successfully implemented and documented the feature to define a single experiment key (selection mode) for all trials under an experiment. The implementation:
UsingFeatureFlag(),UsingConfigurationKey(), andUsingCustomMode()methodsUsingVariantFeatureFlag()andUsingOpenFeature()in respective packagesAll 1775 tests pass, demonstrating that the changes are non-breaking and work correctly across the entire codebase.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.