-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DeepSeek in benchmarks and plugin #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlebSolovev
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, everything looks very fine, just some small bugs should be fixed 🤝
Thank you for dealing with new LLM services support, I'm happy you managed to do it! Especially, that fast ⚡️
src/benchmark/framework/experiment/setupDSL/benchmarkingBundleBuilder.ts
Outdated
Show resolved
Hide resolved
GlebSolovev
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DeepSeek API as a standalone service and support its choice in Benchmarks and Plugin settings. Due to API compatibility, the service is almost identical to the OpenAI Service. However, we decided to separate the logic into another service and not to manipulate existing service params because:
It is semantically a new LLMService.
The API is changing and could be extended. If we made it another way around, it would become painful to modify the code.
At the moment, service is not tested enough due to an outage of the public DeepSeek API, extreme downtime and queues.