FL-24489: Adjusted prev live template logic
#25
Conversation
There was a problem hiding this comment.
AndroidKotlinTemplateContextType is meant to be generic for all Android code, correct? It may be worth having it in a more generic module than Compose, since it would apply to any other Android-specific live templates.
LGTM otherwise, from the perspective of Android Studio.
Compose Preview template `prev` in IJ/AS now only shows up for Android source set. The hierachy of Kotlin contexts is replicated inside the "Android" group within the context selection. Compose Preview template `prev` in Fleet uses proper annotation, based on the source set where it is called: - For Android, it uses androidx Preview annotation. - For Common & JVM it uses jetbrains Preview annotation. - For iOS and other sources it is not showing up at all. Also, the template in Fleet shows up only for top-level declarations, fixing FL-23101, and `prevCol` template is only enabled for Android source set. GitOrigin-RevId: 6537741769014f659a1daa05318d2d8e541df6b7
intellij-monorepo-bot
force-pushed
the
ilia.bogdanovich/FL-24489-prev-live-template
branch
from
622f7f1 to
2731abd
Compare
|
Hi @andymagee, thanks for the comment! |
|
Looks good to me, thanks! |
|
OK, great! Would you be able to merge it into the Android Studio codebase? And I'll merge it into our |
Sure thing, will do. |
|
Perfect! Changes been merged into IJ master. |
|
Just merged into our main branch as well. Mirroring to AOSP's |
|
Great, thank you! |
3 participants
Compose Preview template
previn IJ/AS now only shows up for Android source set. The hierachy of Kotlin contexts is replicated inside the "Android" group within the context selection. Compose Preview templateprevin Fleet uses proper annotation, based on the source set where it is called:prevColtemplate is only enabled for Android source set.GitOrigin-RevId: 785a7e85338dd3ec5f98c242b139d3fe6d3c75ef