Skip to content

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 6, 2023

ValueNotContainedMutabilityCompiledNamesDiffer

There are some limitations:

  • In FSharpAttributesUtil, the elementFactory.CreateEmptyAttributeList only works for implementation files.
  • implMember.GetDeclarations() in tryFindBindingPairFromTopReferencePat does not contain the signature declaration. I need to look for it via the parent.
  • Removing disableFormatter did not work for me. It always inserted an additional newline between the attributeList and the val node.

@nojaf nojaf force-pushed the ValueNotContainedMutabilityCompiledNamesDiffer branch from 6e37c3d to bb5c80b Compare July 10, 2023 13:03
@nojaf nojaf marked this pull request as ready for review July 17, 2023 12:02
@nojaf nojaf force-pushed the ValueNotContainedMutabilityCompiledNamesDiffer branch from bb5c80b to 578f5d7 Compare July 17, 2023 14:22
@nojaf nojaf changed the base branch from net232 to net233 July 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant