QuickFix: RemoveUnusedNamedPattern

[edgarfgp]

Superseeds #463

[edgarfgp]

There are still some unrelated test failing. So i would wait until this is fixed in main. Based on this comment #945 (comment)

[edgarfgp]

@auduchinok Any clues on why all the related test in the CI failed ? with

  Failed Record 01 [461 ms]
  Error Message:
   TearDown : LoggedErrors : No error highlightings found for QuickFix
--- EXCEPTION #1/2 [AssertionException]
Message = “No error highlightings found for QuickFix”

I can see this working locally

[auduchinok]

@auduchinok Any clues on why all the related test in the CI failed ? with

There may be an error the prevents FCS from reporting the unused pattern one. The test environment is somewhat different from a real project, even though we try to make it similar enough. I should try running it myself to tell more.

[auduchinok]

@edgarfgp Could you please rebase on main to fix the conflicts?

[edgarfgp]

@auduchinok Done. No conflicts though.

[auduchinok]

This branch only executes when the next pattern is on another line. isInlineSpaceOrComment won't go through line separators, so it would only cover some tokens on the next line. Why do we check whitespace/comments on another line when deleting a pattern on the current line?

Why not go to subsequent nodes from the pattern that is being deleted instead? And have you had a chance to test the formatter, as suggested previously? Maybe it can do it all for you after all?

[edgarfgp]

Why do we check whitespace/comments on another line when deleting a pattern on the current line?

Because I have not found a better way to deal with cases like:

Before
match x with
| { F1 = {caret}f1
     // I'm a comment
     F2 = f2 // I'm a comment
     F3 = {caret}}f3} -> ()

After
match x with
| {  // I'm a comment
     F2 = f2
     F3 = f3} -> () 

And have you had a chance to test the formatter, as suggested previously? Maybe it can do it all for you after all?

No. Assuming that you are referring to .FormatNode() function

[auduchinok]

No. Assuming that you are referring to .FormatNode() function

No, I meant just deleting the meaningful pattern nodes, expecting all the newlines and whitespaces to be handled by the formatter.

[auduchinok]

So, yeah, it doesn't handle this new line yet. I'll need to add some rules to the formatter.

[edgarfgp]

Thanks. Looking forward to finish this PR :)

[edgarfgp]

@auduchinok Anything I can help with to unblock this PR ?