Skip to content

Conversation

@errnesto
Copy link

This simply adds react18 and react-dom18 as valid peer dependcies so this can be used with a current react version

@platramos
Copy link

Merging this in would be great because enabling peer-dependencies is a hacky solution and an anti-pattern. Thanks for making the changes @errnesto

@vandijkstef
Copy link

+1, please merge and send it! 🥳

@katistix
Copy link

+1, would really need this! Merge and release please!

@davidnoelopez
Copy link

+1, it would be great!

@BenPreston
Copy link

Yes please merge 🙏

@neilor
Copy link

neilor commented Aug 14, 2023

When you're waiting for this, I published a package called @whats-tools/react-qr-reader which unlocks react v18 at peer dependencies. => v3.0.0-alpha.3

I've tested for a while in one particular react v18 project using npm i --force. But the best way I passed through it without adding any problems with another packages vulnerabilities was publishing this new project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants