Display X-Geo-Country info #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only available if the CDN sends an X-Geo-Country header
not sure about what it does though. Just for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: wouldn't it be nice to display the visitor's location in the 404 alert email? This way the Wordpress admin won't have to waste time looking for this information online.
The X-Geo-Country header isn't available by default but may be added if the website uses a CDN (the wordpress admin might need to contact their CDN support to enable it).
This is a sample alert with the X-Geo-Country set:
And this is an example when it doesn't exist:
@Joel-James, you may want to review my modifications. I admit I didn't understand what the apply_filter function does but used it anyway to keep your code consistent. For example in line 231 of the file class-jj4t3-404-data.php. Luckily it seems to work. :)