-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Co vs CO #43
Co vs CO #43
Conversation
please note that the first commit on this PR is the same as #44 |
975044a
to
9e87071
Compare
Does it even make sense to keep typer as a dependency with this change? Seems like we're entirely working around it and essentially just using click (which is also totally fine, I like click too) |
Writing a CLI with typer is much easier than with We can wait for the |
Now that I think more about it, I'll implement the move to pure |
I +1'd your PR, hopefully it makes it in! |
The click changes look good, I'm actually surprised how similar they are (though agreed typer is easier when it works) |
Thanks for approving the PR. I will prepare a new tag/release... |
Thank you! |
closes #42
Not sure how to address this issue.
My first try was to exclude from the CLI thge pollutants that would confuse typer.
Currently, I use
click
to construct the sub commands.