[SPARKNLP-1091] AutoGGUFModel embeddings support #14433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinTDHa
changed the title
maziyarpanahi
changed the base branch from
master
to
release/551-release-candidate
maziyarpanahi
approved these changes
Oct 18, 2024
|
@DevinTDHa let's make the changes and have this feature as |
Hi @maziyarpanahi, Sounds good to me! I will update this PR to inlude the new annotator. |
…aCppInferenceProperties
- also adds embedding support for AutoGGUFModel, as it already has the parameter
- Also adds example notebook
DevinTDHa
force-pushed
the
feauture/SPARKNLP-1080-autogguf-embeddings
branch
from
bed0f06
to
13c06a8
Compare
DevinTDHa
force-pushed
the
feauture/SPARKNLP-1080-autogguf-embeddings
branch
from
7fd370f
to
b59a339
Compare
DevinTDHa
changed the base branch from
release/551-release-candidate
to
master
|
@maziyarpanahi I have updated this PR to include the functionaltiy as a new Annotator AutoGGUFEmbeddings |
DevinTDHa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables proper embedding support for AutoGGUFModels with a new annotator called AutoGGUFEmbeddings. The returned annotations will then contain an embedding vector, similar to the other sentence embedding annotators.
This PR also contains an end-to-end example notebook:
https://github.com/JohnSnowLabs/spark-nlp/blob/b59a339164d2a2c37633e2c9ec12762134c5c2c6/examples/python/llama.cpp/llama.cpp_in_Spark_NLP_AutoGGUFEmbeddings.ipynb
The pretrained model is available at
#14448
How Has This Been Tested?
Old and new tests passing on Scala and python side.
Types of changes