fix CFrame ToWorldSpace/ToObjectSpace function type #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roblox allows for passing in multiple CFrame's and Vector3's into these functions, but doesn't reflect this in their types. This change fixes this so that they no longer produce type errors.
Owner
|
I remember someone previously submitted the same change. I was hesitant about this because it will break documentation (Roblox's documentation file assumes a one-parameter variant of these functions) |
Author
|
is there any way around this? |
Contributor
Contributor
|
Documentation update is live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roblox allows passing in multiple CFrame's or Vector3's in functions that convert these into either World space or Object space.
This commit fixes the types to properly reflect that behavior and affects the following functions:
ToWorldSpaceToObjectSpacePointToWorldSpacePointToObjectSpaceVectorToWorldSpaceVectorToObjectSpace