Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mongodb-memory-server dependency #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix mongodb-memory-server dependency #151

wants to merge 2 commits into from

Conversation

chmanie
Copy link
Member

@chmanie chmanie commented Feb 9, 2022

It just wasn't there. Then I upgraded it, change the API calls and re-wrote the package-lock.json.

I also fixed some ObjectID calls that were failing now for some reason.

@chmanie chmanie self-assigned this Feb 9, 2022
@chmanie chmanie requested a review from rdig February 9, 2022 11:07
rdig
rdig approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok so far.

The only think I'm concerned a bit is how will this handle under load. But I guess we can test this on QA and come back to it if it turns out to be problematic.

@chmanie
Copy link
Member Author

chmanie commented Feb 9, 2022

But I guess we can test this on QA

Yes I think we should definitely do that!

@chmanie chmanie changed the title Fix mongodb-memory-server dependeny Fix mongodb-memory-server dependency Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

Assignees

@chmanie chmanie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chmanie @rdig