-
-
Notifications
You must be signed in to change notification settings - Fork 582
Module manager test #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module manager test #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What determines the current browser for pnpm e2e
?
Browser on which we're currently are or what?
And tests run will iterate on both browsers and run tests for both?
And fix CodeQL issues.
And it isn't possible to run it on local machine, only on CI, are you think about to add it also as a package.json script?
a19814b
to
44c590f
Compare
pnpm e2e runs by default on chrome, pnpm e2e:firefox runs on firefox IDK how to trigger them here, before merge, but they were running on my fork |
@govza I'm also wondering about use case of local run, and i think we can skip it, because it should work only on CI. And why it isn't working here, i don't freaking know, i was trying everything to get knowledge, why it can't work. But overall there's something wrong with settings of repo, because on my fork it also works better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM very good work :)
Priority*
Purpose of the PR*
Run tests for separated features
Changes*
Created
e2e-moduler
GH workflowHow to check the feature
Closes #937