Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URE Integration: Fix the level at which the View Admin As group appears in the URE Custom Capabilities UI #135

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pbiron
Copy link

@pbiron pbiron commented Jul 29, 2024

Fixes #134

Proposed Changes

  • change the level at which the VAA group is added from 3 to 2.

Screenshot w/ PR applied

vaa-ure-custom-caps-after-pr

Compare the above screenshot with the one in #134

…rs in the URE Custom Capabilties UI: change the level from 3 -> 2.
@pbiron
Copy link
Author

pbiron commented Jul 29, 2024

Note: I created the PR in a separate branch of my fork of VAA (which was branched from the current VAA dev branch) and had hoped that GitHub would make the PR against VAA dev but it did it against master. Sorry about that.

@JoryHogeveen
Copy link
Owner

Hi @pbiron
Thank you for the PR!
I am wondering whether this is a change in URE which needs backwards compatibility. Do you know of any changes in the URE code lately that lead to this change?

@JoryHogeveen JoryHogeveen changed the base branch from master to dev July 30, 2024 09:07
@JoryHogeveen JoryHogeveen self-assigned this Jul 30, 2024
@JoryHogeveen JoryHogeveen added this to the 1.8.10 milestone Jul 30, 2024
@pbiron
Copy link
Author

pbiron commented Jul 30, 2024

As far as I know, it's not a recent change in URE. I noticed the problem a long time ago (don't remember exactly how long ago, but at least 2-3 years) but promptly forgot about it.

I was reminded of it the other day when I had to fix one of my own plugins that also hooks into ure_capabilities_groups_tree, so I opened the ticket/PR before I forgot about it again ;-)

@JoryHogeveen
Copy link
Owner

Okidoki, in that case I doubt that there is a need to support legacy versions so I'm going ahead an merge this PR, thanks again!
It will be release in the next MR (no idea when that would be as this is the first patch for it).

@JoryHogeveen JoryHogeveen merged commit 0abbf46 into JoryHogeveen:dev Jul 30, 2024
@pbiron
Copy link
Author

pbiron commented Jul 30, 2024

certainly no rush for you to release a new version just for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAA group added a wrong level in URE's "Custom Capabilities" UI
2 participants