Skip to content

Ignore comment lines when detecting delimiters #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore comment lines when detecting delimiters #2357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CsvHelper/Configuration/ConfigurationFunctions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public static string GetDelimiter(GetDelimiterArgs args)
var match = Regex.Match(text, newLine);
var line = match.Success ? text.Substring(0, match.Index) : text;

if (line.Length > 0)
if (line.Length > 0 && !(config.AllowComments && line[0] == config.Comment))
{
var delimiterCounts = new Dictionary<string, int>();
foreach (var delimiter in config.DetectDelimiterValues)
Expand Down
16 changes: 16 additions & 0 deletions tests/CsvHelper.Tests/Parsing/DetectDelimiterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,5 +303,21 @@ public void GetDelimiter_TextHasEmptyLines_DetectsDelimiter()
var delimeter = ConfigurationFunctions.GetDelimiter(new Delegates.GetDelimiterArgs(s.ToString(), config));
Assert.Equal(";", delimeter);
}

[Fact]
public void GetDelimiter_TextHasComments_DetectsDelimiter()
{
var s = new StringBuilder();
s.AppendLine("#comment,,,");
s.AppendLine("Id;Name");
s.AppendLine("1;2");
var config = new CsvConfiguration(CultureInfo.InvariantCulture)
{
AllowComments = true,
Comment = '#',
DetectDelimiter = true,
};
Assert.Equal(";", ConfigurationFunctions.GetDelimiter(new Delegates.GetDelimiterArgs(s.ToString(), config)));
}
}
}