Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions from analysis_integrals #152

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Use functions from analysis_integrals #152

merged 3 commits into from
Sep 11, 2024

Conversation

JoshuaLampert
Copy link
Owner

@JoshuaLampert JoshuaLampert commented Sep 11, 2024

See the discussion in #151 (comment).
I'm not sure if that's what you had in mind, @ranocha, but this should work, shouldn't it? We know that the functions within cb.affect!.analysis_integrals have the same order as the entries of the NamedTuple ints = integrals(cb). So we can just get the functions from there.

TODO:

  • Add a test

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (6ab2051) to head (71d8dce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files          18       18           
  Lines        1667     1667           
=======================================
  Hits         1630     1630           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I had in mind. Thanks!

@JoshuaLampert JoshuaLampert merged commit 11355c0 into main Sep 11, 2024
17 checks passed
@JoshuaLampert JoshuaLampert deleted the patch1 branch September 11, 2024 11:56
@JoshuaLampert JoshuaLampert added the bug Something isn't working label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants