Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @test_trixi_include for some upwind tests #156

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

JoshuaLampert
Copy link
Owner

Before we rewrote the testing mechanism again in the cases where we wanted to reuse an elixir, but exchange the solver in the tests (to test upwind solvers). We could, however, simply reuse @test_trixi_include by passing the kwarg solver to reach the same, but being shorter, more readable and more consistent. I don't remember why I didn't opt for this solution in the first place.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (824298a) to head (ddcce93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          19       19           
  Lines        1776     1776           
=======================================
  Hits         1740     1740           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert merged commit 198132f into main Sep 24, 2024
17 checks passed
@JoshuaLampert JoshuaLampert deleted the restructure-upwind-tests branch September 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants