Merge pull request #48 from JosiahParry/v0.2.4

Prepare CRAN release
JosiahParry · Feb 17, 2024 · 23095a5 · 23095a5
2 parents 9e52a6b + 3c02bcb
commit 23095a5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -1,5 +1,7 @@
 # Generated by roxygen2: do not edit by hand
 
+S3method("[",spacetime)
+S3method("[[",spacetime)
 S3method(activate,spacetime)
 S3method(as_spacetime,sf)
 S3method(print,spacetime)

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# sfdep 0.2.4
+
+- Dexter Locke is now the maintainer of sfdep
+- Address failing CRAN checks h/t [@rsbivand](https://github.com/rsbivand) <https://github.com/JosiahParry/sfdep/pull/43>
+- Address bug in local Gi/* statistics
+
 # sfdep 0.2.3
 
 - remove readr suggestion to pass `noSuggests` from CRAN. Much minuscule tasks for the overlords.

diff --git a/R/spacetime-methods.R b/R/spacetime-methods.R
@@ -2,11 +2,12 @@
 # Selection ---------------------------------------------------------------
 # Selection method
 # to do  update `times` attribute when subset and data is active
-
+#' @export
 `[.spacetime` <- function(x, ...) {
   NextMethod()
 }
 
+#' @export
 `[[.spacetime` <- function(x, ...) {
   NextMethod()
 }

diff --git a/tests/testthat/test-node_get.R b/tests/testthat/test-node_get.R
@@ -26,7 +26,7 @@ test_that("nbs is spdep compliant", {
     mutate(
       nb = node_get_nbs(),
       elist = node_get_edge_list(),
-      wt = node_get_edge_col(elist, "len")
+      wt = node_get_edge_col(nb, "len")
     )
 
 
@@ -48,7 +48,7 @@ test_that("nbs is spdep compliant", {
 
   expect_equal(
     nb,
-    lapply(ig_adj_list, as.integer),
+    lapply(ig_adj_list, function(.x) unique(.x)),
     ignore_attr = TRUE
   )