Skip to content

Add market transactions pagination #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

DzhideX
Copy link
Collaborator

@DzhideX DzhideX commented Jan 24, 2025

The PR aims to fix the issue described here: #6438

cc @Lezek123

…ctionsPagination hook, accomodate code to integrate pagination
Copy link
Collaborator

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it fixes the original issue, although a better solution would be to fetch only a page of ammTransaction at once, instead of pre-fetching all of them.

@Lezek123 Lezek123 merged commit a7027e2 into Joystream:dev May 9, 2025
4 of 8 checks passed
Lezek123 added a commit to Lezek123/atlas that referenced this pull request May 9, 2025
* Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination

* Remove unnecessary comment

* Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts

---------

Co-authored-by: Leszek Wiesner <[email protected]>
Lezek123 added a commit that referenced this pull request May 9, 2025
* Add YPP referral pagination (#6503)

* Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work

* Update VITE_YOUTUBE_SYNC_API_URL in .env

* Add market transactions pagination (#6505)

* Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination

* Remove unnecessary comment

* Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts

---------

Co-authored-by: Leszek Wiesner <[email protected]>

* Update CHANGELOG and bump versions

---------

Co-authored-by: Edvin Dzidic <[email protected]>
Lezek123 added a commit to Lezek123/atlas that referenced this pull request May 9, 2025
* Add YPP referral pagination (Joystream#6503)

* Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work

* Update VITE_YOUTUBE_SYNC_API_URL in .env

* Add market transactions pagination (Joystream#6505)

* Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination

* Remove unnecessary comment

* Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts

---------

Co-authored-by: Leszek Wiesner <[email protected]>

* Update CHANGELOG and bump versions

---------

Co-authored-by: Edvin Dzidic <[email protected]>
Lezek123 added a commit to Joystream/gleev that referenced this pull request May 9, 2025
* Add YPP referral pagination (Joystream#6503)

* Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work

* Update VITE_YOUTUBE_SYNC_API_URL in .env

* Add market transactions pagination (Joystream#6505)

* Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination

* Remove unnecessary comment

* Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts

---------



* Update CHANGELOG and bump versions

---------

Co-authored-by: Edvin Dzidic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants