Sort by recoverable balance and show vesting total, claimable (#2807) #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
added
community-dev
thesan
requested changes
Dec 21, 2022
Comment on lines
+40
to
+44
| <> | ||
| <TokenValue value={locked.add(vested)} /> | ||
| <TokenValue value={locked} /> | ||
| </ValueCell> | ||
| <TokenValue value={vested} /> | ||
| </> |
There was a problem hiding this comment.
The current solution doesn't work:
This component is given the DeriveBalancesVesting which doesn't include vestedClaimable but:
Recoverable is vestedClaimable and what's actually locked is locked - vested + vestedClaimable (although there might be different way to get to these result) and finally the total should always be locked.
So one way to fix this is to pass vestedClaimable to the VestingLockListItem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2807 part 1+2