Update MyVotes (#2991, #2986) #4262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrlschwb
added
jsg-code-review
builders-wg-code-review
and removed
jsg-code-review
labels
traumschule
suggested changes
Mar 29, 2023
There was a problem hiding this comment.
- [USERSNAP] Restore Votes does not upate My Votes #2991: I don't see an automatic update after restoring. After switching to another page and back to election restored votes are shown correctly.
- After voting
My Votesis not updated #2986: This seems to work on https://pioneerapp.xyz already?
| setItem(key, value) | ||
| document.dispatchEvent(new CustomEvent(`storage_event_${key}`, {})) |
There was a problem hiding this comment.
From the code it's not obvious what we are saving and why. Maybe add a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issues #2991, #2986