Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore insert table button #4444

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

restore insert table button #4444

wants to merge 1 commit into from

Conversation

traumschule
Copy link
Contributor

reviewing #4032 it looks like a mistake to remove the button

@vercel
Copy link

vercel bot commented Jun 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jun 17, 2023 5:58pm

traumschule
traumschule commented Jun 17, 2023
View reviewed changes
Copy link
Contributor Author

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested
edittable

@traumschule traumschule added high-prio community-dev issue suitable for community-dev pipeline builders-wg-code-review labels Jun 17, 2023
@thesan
Copy link
Member

thesan commented Jun 19, 2023

@traumschule I'm confused, is this problem not happening anymore: #4032 (comment) ?

@traumschule
Copy link
Contributor Author

it's fine for me.

@chrlschwb
Copy link
Contributor

@traumschule is the above screenshot the "preview" modal?
Preview mode works well for me as well, but the actual post displays like this.
https://dao-git-fork-traumschule-patch-18-joystream.vercel.app/#/forum/thread/460?post=4051

There is some conflict between the ckeditor plugin and the ReactMarkdown component.
Ckeditor uses HTML markdown, while the current setting uses GFM.

thesan
thesan requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shouldn't get merged until this #4444 (comment) gets fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traumschule @thesan @chrlschwb