Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📨 Notify users of proposal discussions #4849

Merged
merged 6 commits into from
May 28, 2024

Conversation

thesan
Copy link
Member

@thesan thesan commented May 16, 2024

Addresses #4281

(Also fixes some problems with the forum posts notifications).

@thesan thesan requested a review from kdembler May 16, 2024 09:23
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview May 17, 2024 1:26pm
pioneer-2 ✅ Ready (Inspect) Visit Preview May 17, 2024 1:26pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview May 17, 2024 1:26pm

(not essential but still nice to have IMO)
Copy link
Member

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesan I have done a basic review of the code, wasn't cery thorough, but everything looks okay and I also ran a few tests and worked as expected so LGTM

@thesan thesan merged commit b662b3e into dev May 28, 2024
9 checks passed
@thesan thesan deleted the feature/proposal-discussion-notif branch May 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants