Fixes #390: serialization issue for relationships#398
Open
thebluber wants to merge 1 commit intoJsonApiClient:masterfrom
Open
Fixes #390: serialization issue for relationships#398thebluber wants to merge 1 commit intoJsonApiClient:masterfrom
thebluber wants to merge 1 commit intoJsonApiClient:masterfrom
Conversation
gaorlov
requested changes
Jun 1, 2023
Collaborator
gaorlov
left a comment
gaorlov
left a comment
There was a problem hiding this comment.
Thanks for contributing!
Please merge in main to get tests running in the PR and please add this PR to the CHANGELOG.md
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the jsonapi specification https://jsonapi.org/format/#document-resource-object-attributes
attributes MUST NOT contain a relationship member.
There's a serialization issue introduced with Pull request #386 as described in issue #390.