Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for new version of aiida-core #142

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Update tests for new version of aiida-core #142

merged 9 commits into from
Nov 10, 2023

Conversation

PhilippRue
Copy link
Member

AiiDA-core version is part of the caching files and thus these need to be recreated

@PhilippRue
Copy link
Member Author

Only fix tests where caching works, others are deactivated (see issue #143)

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (f6814ab) 68.07% compared to head (dd7ef25) 54.04%.
Report is 45 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #142       +/-   ##
============================================
- Coverage    68.07%   54.04%   -14.04%     
============================================
  Files           99      100        +1     
  Lines        14007    14006        -1     
============================================
- Hits          9535     7569     -1966     
- Misses        4472     6437     +1965     
Files Coverage Δ
aiida_kkr/__init__.py 100.00% <100.00%> (ø)
aiida_kkr/cmdline/visualization/__init__.py 29.72% <100.00%> (ø)
aiida_kkr/parsers/kkr.py 64.60% <100.00%> (+2.10%) ⬆️
aiida_kkr/parsers/kkrimp.py 88.05% <100.00%> (+30.78%) ⬆️
aiida_kkr/tools/__init__.py 90.00% <100.00%> (+0.52%) ⬆️
aiida_kkr/tools/find_parent.py 91.66% <100.00%> (+2.19%) ⬆️
aiida_kkr/tools/tools_kkrimp.py 73.70% <100.00%> (+0.49%) ⬆️
tests/tools/test_find_parent.py 100.00% <100.00%> (ø)
aiida_kkr/workflows/jijs.py 82.26% <66.66%> (-2.96%) ⬇️
aiida_kkr/calculations/kkrimp.py 55.31% <75.00%> (+4.55%) ⬆️
... and 11 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhilippRue PhilippRue merged commit f5cb626 into develop Nov 10, 2023
12 of 14 checks passed
@PhilippRue PhilippRue deleted the fix_tests branch November 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant