-
Notifications
You must be signed in to change notification settings - Fork 27
Change clenshaw!/horner! to mutate first argument #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 17 17
Lines 3156 3156
=======================================
Hits 2434 2434
Misses 722 722 ☔ View full report in Codecov by Sentry. |
I disabled |
Why is disabling this necessary? ApproxFun is only a requirement in the docs/Project.toml, so not for loading the package. |
The documentation tests break since it tries all examples and there’s a circular dependency |
I didn't realize there were documentation tests... Where are they? The latest commit had a checkmark (5260921), so nothing that's being tested or built failed. |
Oh I see that when you bumped the version to 0.17 (denoting breaking change) that it was unable to load ApproxFun due to its dependency restriction. (https://github.com/JuliaApproximation/FastTransforms.jl/actions/runs/12596799219/job/35108595588#step:4:54). There must be a way around this... because it basically works for patch releases. |
Maybe the example should live in https://github.com/JuliaApproximation/ApproxFunExamples |
If the docs fail to build, the PR can still be merged. A new minor release will prompt ApproxFun to bump its patch release, which can then allow the docs to be rebuilt here... The only thing would be merging with a x instead of a ✓. |
Then it wouldn’t have caught the actual bugs in the documentation. moving it to ApproxFunExamples makes more sense |
I also removed Reexport since it's bad practice (technically makes any breaking change in other packages a breaking change here) |
Probably this fixes #213? |
To make the interface for
clenshaw!
more consistent withsum!
,cumsum!
,diff!
the vector being mutated should be first.This goes with JuliaApproximation/RecurrenceRelationships.jl#13 which also supports the
dims
keyword